Skip to content

Conversation

@gdalle
Copy link
Member

@gdalle gdalle commented Jan 20, 2025

Complex number compatibility (first order only):

  • Make sure that pullback returns the product with the adjoint (conjugate transpose) of the Jacobian
  • Add conjugation in reverse-mode Jacobians, dense and sparse
  • Document that we assume functions to be holomorphic when dealing with complex inputs

Complex number testing:

  • Create test scenarios with complex holomorphic functions, first order only
  • Test these scenarios with FiniteDiff (ForwardDiff doesn't work)

@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 96.72131% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.61%. Comparing base (4feb596) to head (af0aa37).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...fferentiationInterface/src/first_order/jacobian.jl 83.33% 1 Missing ⚠️
...ifferentiationInterface/src/misc/from_primitive.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #687      +/-   ##
==========================================
- Coverage   97.61%   97.61%   -0.01%     
==========================================
  Files         114      115       +1     
  Lines        5623     5650      +27     
==========================================
+ Hits         5489     5515      +26     
- Misses        134      135       +1     
Flag Coverage Δ
DI 98.74% <93.54%> (-0.03%) ⬇️
DIT 95.39% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review January 21, 2025 13:38
@gdalle gdalle merged commit 66f7ff3 into main Jan 21, 2025
46 of 91 checks passed
@gdalle gdalle deleted the gd/holo branch January 21, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants