Cherry-pick #204 to a new release-0.3 branch that supports Julia 0.4 #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to include v0.6 fixes (JuliaDiff#184)" This reverts commit 62ad04b. If higher minimum versions are only needed for 0.6, they should be loosened here Upper bound this branch so it is not installable on 0.6.
…aDiff#204) (cherry picked from commit 6c61b61)
Member
|
If this is only to make PkgEval happy, I'm fine with doing the backport this time (since we already have everything laid out), but in the future I'd rather just bump DiffBase's Julia lower bound version requirement to match ForwardDiff/ReverseDiff than take on the development overhead of supporting a Julia version which has already gone the way of the dinosaur (in my mind, anyway). |
Contributor
Author
|
Next time do that before tagging a version that causes downstream test failures. If this wasn't a test addition pointing out an obvious bug with a simple fix, I'd agree. |
Contributor
Author
|
Julia 0.4 is still used in quite a few places. If it isn't broken, try not to make things any worse there. |
Contributor
Author
|
Good to go here, and tag as 0.3.5? |
Contributor
Author
|
ping |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #185 (comment), would like to change the target branch to that once it's created. DiffBase 0.0.5 still supports Julia 0.4 and caused ForwardDiff 0.3.4, the last tag here that supported 0.4, to now fail its tests - https://github.com/JuliaCI/pkg.julialang.org/blob/69282b38ea4ea43a5b300862eac40d89bbf03b7a/logs/ForwardDiff_0.4.log
In local testing, this fixes it.