Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Use Conda for CI and fix deprecations #64

Merged
merged 10 commits into from Jun 10, 2019

Conversation

@sjkelly
Copy link
Contributor

sjkelly commented Jun 7, 2019

This builds upon #63. The docker container used for CI was using Julia 0.6 so I adjusted it to now use Conda as well. In addition there are several deprecation fixes for PyCall.

There are some outstanding issues:

  • UnitTetrahedronMesh and others seem unexported into the Python FEniCS library, but still exist in the CPP code.
  • MPI is not supported in the Conda build and was disabled temporarily
  • If installing via Conda should we fix the fenics version to ensure API compatibility?

Should fix #61, #52, and help #28 and #12.

@ChrisRackauckas ChrisRackauckas requested a review from ysimillides Jun 7, 2019
@ChrisRackauckas

This comment has been minimized.

Copy link
Member

ChrisRackauckas commented Jun 7, 2019

How does this do on Mac and Windows?

@sjkelly

This comment has been minimized.

Copy link
Contributor Author

sjkelly commented Jun 7, 2019

FEniCS AFAIK is not supported on windows natively. It supposedly runs in WSL. I can test this later to confirm. I guess there should be a warning during the build step to notify users.

@sjkelly

This comment has been minimized.

Copy link
Contributor Author

sjkelly commented Jun 7, 2019

OSX seems fine with Travis.

@ChrisRackauckas

This comment has been minimized.

Copy link
Member

ChrisRackauckas commented Jun 7, 2019

Alright, seems fine with me if @ysimillides likes it. The main reason we switched to the Docker was because the original installation method was difficult to deal with. But if this is simpler, then yeah, awesome. Just put a warning for Windows.

@ysimillides

This comment has been minimized.

Copy link
Member

ysimillides commented Jun 10, 2019

Hey everything looks really good to me! Just a minor issue, we might want to include the newer julia versions in the testing script.

@ChrisRackauckas

This comment has been minimized.

Copy link
Member

ChrisRackauckas commented Jun 10, 2019

Yeah, that would probably be a good idea. I don't think it's blocking to this PR though.

@sjkelly sjkelly force-pushed the sjkelly:sjk/conda2 branch from 36dacd3 to 7f11dc3 Jun 10, 2019
@ChrisRackauckas ChrisRackauckas merged commit b440534 into JuliaDiffEq:master Jun 10, 2019
@sjkelly

This comment has been minimized.

Copy link
Contributor Author

sjkelly commented Jun 10, 2019

Thanks! I managed to slip in my sys -> Sys fix with not a second to spare :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.