Update type declaration syntax for 0.6#28
Merged
Conversation
Member
|
LGTM, thanks! I won't backport this since it's non-essential. No idea though when we'll tag the next minor version though, since there isn't much happening here at the moment. |
|
The deprecation is a little annoying, any harm in tagging a patch release? |
mortenpi
pushed a commit
that referenced
this pull request
Apr 21, 2017
(cherry picked from commit 9bd77b0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the deprecation warnings on 0.6. Note though that the tests won't pass here until #27 is merged.