"Permission denied" when running doctests from runtests.jl

[timholy]

On GitHub Actions, from a (private) package that does this:

using Documenter
DocMeta.setdocmeta!(SteroidComputationalChemistry, :DocTestSetup, :(using SteroidComputationalChemistry, MolecularGraph, ElectronDisplay); recursive=true)
doctest(SteroidComputationalChemistry, manual = false)

I'm seeing this:

[ Info: SetupBuildDirectory: setting up build directory.
[ Info: Doctest: running doctests.
[ Info: Skipped ExpandTemplates step (doctest only).
[ Info: Skipped CrossReferences step (doctest only).
[ Info: Skipped CheckDocument step (doctest only).
[ Info: Skipped Populate step (doctest only).
[ Info: Skipped RenderDocument step (doctest only).
Doctests: SteroidComputationalChemistry: Error During Test at C:\Users\runneradmin\.julia\packages\Documenter\FuXcO\src\Documenter.jl:830
  Test threw exception
  Expression: all_doctests()
  SystemError (with C:\Users\RUNNER~1\AppData\Local\Temp\jl_XDdaUo): rmdir: Permission denied
  Stacktrace:
   [1] systemerror(::Symbol, ::Int32; extrainfo::String) at .\error.jl:168
   [2] #systemerror#48 at .\error.jl:167 [inlined]
   [3] rm(::String; force::Bool, recursive::Bool) at .\file.jl:286
   [4] (::Documenter.var"#all_doctests#35"{Bool,Array{Regex,1},Array{Module,1}})() at C:\Users\runneradmin\.julia\packages\Documenter\FuXcO\src\Documenter.jl:826
   [5] macro expansion at C:\Users\runneradmin\.julia\packages\Documenter\FuXcO\src\Documenter.jl:830 [inlined]
   [6] macro expansion at C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.5\Test\src\Test.jl:1115 [inlined]
   [7] doctest(::Nothing, ::Array{Module,1}; fix::Bool, testset::String, doctestfilters::Array{Regex,1}) at C:\Users\runneradmin\.julia\packages\Documenter\FuXcO\src\Documenter.jl:830

This particular error only happens on Windows. Any ideas?

[KristofferC]

My guess is that files within the temporary directory the doctests run in are open, and then Windows doesn't allow for its deletion. Should probably be made non-fatal from Documenter's side (just warn instead) but it might also be good to check why the doctests keep files open in the package.

[timholy]

I'm betting it was the use of ElectronDisplay to show some svg files as part of the doctests. Justifiably "not my problem"? (in the sense that it shouldn't require package specific intervention, not that I couldn't be the lucky one to fix the bug 😄) A way to gracefully shut down ElectronDisplay might be nice.