Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume branch *is* from fork when not possible to verify. #1969

Merged
merged 2 commits into from Oct 10, 2022
Merged

Conversation

fredrikekre
Copy link
Member

This patch changes the default assumption when verifying if a pull request is coming from a branch or not from true to false.

Fixes #1961, fixes #1965, closes #1966.

This patch changes the default assumption when verifying if a pull
request is coming from a branch or not from true to false.

Fixes #1961, fixes #1965, closes #1966.
@fredrikekre
Copy link
Member Author

Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, nice job sleuthing the GR stuff.

  1. I think this could use a brief CHANGELOG note, since it slightly changes behavior.

  2. Could we also add a small note to the docts, something like

    On GitHub Actions, GITHUB_TOKEN must be present for previews to work, even if DOCUMENTER_KEY is being used to deploy."

    to

!!! note
Pull requests made from forks will not have previews.
Hosting previews requires access to the deploy key.
Therefore, previews are available only for pull requests that were
submitted directly from the main repository.

src/deployconfig.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failures, preview related (in pull requests, not on master) CI failures when trying to push a doc preview
2 participants