-
Notifications
You must be signed in to change notification settings - Fork 499
Quick start :) #1419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick start :) #1419
Conversation
MichaelHatherly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SubhadityaMukherjee. I've added a few inline comments.
I can understand the need for more tutorial/quickstart material for getting started with this kind of stuff, especially more "conversational" content. How do you feel it compares to the content of https://juliadocs.github.io/Documenter.jl/stable/man/guide/? What did you find was missing from that, might be worth iterating of it rather than increasing the size of the docs further?
|
|
||
| The [Package Guide](@ref) provides a tutorial explaining how to get started using Documenter. | ||
|
|
||
| A quickstart version of the guide can be found at [Quickstart]("https://github.com/JuliaDocs/Documenter.jl/blob/master/docs/src/quickstart.md") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use a @ref link for the "quickstart" link rather than linking to the source file directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @MichaelHatherly . Thank you for the review. :)
I felt that as documentation for someone who knows their way around these things it was perfect. But for someone just starting out with Julia/actually developing, it would be a bit hard to follow as many steps that were not related to Documenter.jl were involved.
I had initially written a post on my blog but I was told that it might be a good addition to the documentation here so the PR.
I will fix whatever you mentioned by tomorrow.
Cheers
| 3. Put your code in the folder called src | ||
| 4. Create a folder called docs | ||
| - Follow this structure if you can (most of this is auto generated) | ||
| - DDL.jl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"MyPkg" used above, best to just stick with one name for the examples perhaps.
| - src | ||
| - Project.toml (To take care of related dependencies) | ||
|
|
||
| >Tip: If you have a clean repo you can do this to speed up your workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a !!! tip admonition here might look better.
| sitename = "DDL Documentation", | ||
| repo = "https://github.com/SubhadityaMukherjee/DDL.jl" | ||
| ) | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indentation in code block above.
| 5. Learn *markdown* | ||
|
|
||
| It will save your life over and over again. | ||
| Here is the best cheat sheet I found to learn it [CHEAT](https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.julialang.org/en/v1/stdlib/Markdown/ is the right reference to point to, Julia's Markdown isn't quite standard markdown in some places so would be best to not direct users to something that might have inconsistencies.
| - tests | ||
| - README.md | ||
| - Manifest.toml | ||
| - Project.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this directory structure in a code block rather, since it's nested in a list already the additional nesting doesn't make it stand out enough.
|
|
||
| See the [Index](@ref main-index) for the complete list of documented functions and types. | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unintentional extra blank?
|
Quoting @SubhadityaMukherjee's reply outside of inline comments:
Yes, I followed along in that thread and agree with @mortenpi's final comments. Let's decide exactly where this content fits into the rest of the manual so that it maintains an overall "flow" rather than bifurcating the manual and resulting in duplication. I'd say it probably fits in right at the start of the "Guide" section and shouldn't be very long so that it actually results in a quick start to using the package. Using as much automation in it as well,
Let's also get @mortenpi's take on this prior to doing any fixes, just so you don't have to redo things too much. |
|
Apologies that it took so long for me to reply to this. I do agree with @MichaelHatherly's comments that we should try to see how we can improve the current "Guide" page. I also think it's worth keeping the Divio 4-tiered documentation approach in mind when figuring this out.
Yes, I absolutely agree with this.
However, we shouldn't make this PR too big. Perhaps we could condense this particular PR down to be a PkgTemplates-based quickstart at the start of the Guide page? And then make additional improvements in subsequent PRs? |
| - README.md | ||
| - Manifest.toml | ||
| - Project.toml | ||
| 5. Now in the docs folder make this heirarchy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 5. Now in the docs folder make this heirarchy | |
| 5. Now in the docs folder make this hierarchy |
|
Would be nice to merge this on top of #1451! @SubhadityaMukherjee are you still intrested in working on this? |
|
Let's close this PR, but hopefully we can address the points raised here as part of #2321. |
Hello!
I made a little quickstart guide to Documenter.jl (Previously mentioned in the forums).
I am not particularly sure where you need the file placed but I added it as a quickstart.md file.
Hope it helps out people who are starting out with Julia and this awesome package 😄