Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSM.random_road_position and OSM.random_route! are not reproducible #513

Closed
AayushSabharwal opened this issue Jun 21, 2021 · 1 comment · Fixed by #511
Closed

OSM.random_road_position and OSM.random_route! are not reproducible #513

AayushSabharwal opened this issue Jun 21, 2021 · 1 comment · Fixed by #511
Assignees
@AayushSabharwal
Labels
bug Something isn't working GSOC low priority open street map Related to the Open Street Map space random-reproducibility Related to randomness and/or reproducibility rng Related with random processes and/or reproducibility

Comments

@AayushSabharwal
Copy link
Collaborator

Describe the bug
Both these functions are not reproducible since they use generate_point_in_bounds from OSMX, which doesn't use the model RNG.

Minimal Working Example
Zombies example. Two runs lead to different positions for some agents, which are ones that had a new path generated

Agents.jl version
4.3
@AayushSabharwal AayushSabharwal added bug Something isn't working low priority random-reproducibility Related to randomness and/or reproducibility open street map Related to the Open Street Map space rng Related with random processes and/or reproducibility labels Jun 21, 2021
@Datseris
Copy link
Member

Isn't the fix to this really easy, and you could just add it to e.g. #511 ?

@AayushSabharwal AayushSabharwal self-assigned this Jun 21, 2021
@AayushSabharwal AayushSabharwal mentioned this issue Jun 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AayushSabharwal AayushSabharwal

Labels
bug Something isn't working GSOC low priority open street map Related to the Open Street Map space random-reproducibility Related to randomness and/or reproducibility rng Related with random processes and/or reproducibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OSMSpace Serialization JuliaDynamics/Agents.jl
2 participants
@Datseris @AayushSabharwal