Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Savename expand for nested structs is not working #215

Open
sebastianpech opened this issue Nov 19, 2020 · 1 comment
Open

Savename expand for nested structs is not working #215

sebastianpech opened this issue Nov 19, 2020 · 1 comment
Labels
bug Something isn't working good first issue Easy issue good for newcomers savename Regarding creating "shorthand" names

Comments

@sebastianpech
Copy link
Contributor

As savename works for structs, I think it should also be possible to expand them. This doesn't work at the moment because of

isempty(val) && continue

which, unless defined for the struct, throws an error for non-iterable types.

@sebastianpech sebastianpech added bug Something isn't working good first issue Easy issue good for newcomers savename Regarding creating "shorthand" names labels Nov 19, 2020
@Datseris
Copy link
Member

damn, yes. Simple fix: define our own version of isempty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Easy issue good for newcomers savename Regarding creating "shorthand" names
Projects
None yet
Development

No branches or pull requests

2 participants