-
Notifications
You must be signed in to change notification settings - Fork 15
Deprecate AbstractMatrix inputs #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
My doubt is: do we want to keep the deprecation warning as it is by default (silent unless you activate the option |
|
I think the depwarning always has to be thrown. How did you make it "not being thrown by default"? When I use |
I did not make it. It's the default as of Julia 1.5: |
|
Okay then it is an easy change. Instead of using |
|
Should we make it a regular warning, instead of a deprecation warning, still? |
That's what I always do actually. Don't know if it is good practice or not, but if I know there is some code that will break in the next release, I'd rather press the user to change it as soon as possible instead of passively letting it go after 1 warning. |
(this must be revised later on when DelayEmbeddings is updated to 2.0)
To deal with #106 and the last comments on #102
With this, using
julia --depwarn=yes:But the calculations go as if the matrix had been converted to a
Dataset. (By default, in Julia 1.5+ the deprecation warning is hidden).If this is approved,
src/deprecate.jlcould be extended later on forRecurrenceMatrix{FAN}etc.