Skip to content

Conversation

@TimG1964
Copy link
Contributor

@TimG1964 TimG1964 commented Jul 31, 2024

Added "British_National_Grid" => EPSG{27700} to esriid2code dict.

Added `"British National Grid" => EPSG{27700}` to `esriid2code dict.
Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TimG1964 💯

Notice that we need additional steps to fully address #131. But we can move step by step so that you learn more about it.

Will merge and release a patch after tests are completed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (2ed3a59) to head (5b143a4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files          27       27           
  Lines        1205     1205           
=======================================
  Hits         1149     1149           
  Misses         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliohm juliohm merged commit f6c3e8e into JuliaEarth:main Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants