Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review colorbar creation with viz and viewer #413

Closed
juliohm opened this issue Mar 28, 2024 · 1 comment
Closed

Review colorbar creation with viz and viewer #413

juliohm opened this issue Mar 28, 2024 · 1 comment

Comments

@juliohm
Copy link
Member

juliohm commented Mar 28, 2024

We need to review our treatment of colors in viz and viewer. In particular, we need to look into two areas:

  1. Makie now supports a Makie.Categorical(colorscheme) to convert a continuous colorscheme into a categorical colorscheme with good tick defaults. We need to use that instead of placing our ticks manually.
  2. When using fig, ax, plt = viz(...) it is not always possible to create a colorbar automatically from the plt object, because of missing attributes such as colormap, colorrange, etc. This automatic creation of colorbar is only possible in some Makie builtin functions because they store these attributes.
@juliohm
Copy link
Member Author

juliohm commented Apr 8, 2024

Fixed on master.

@juliohm juliohm closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant