Indentation after importing operators

[yuyichao]

End of line operators doesn't always require indentation on the next line

module A
import Base: *
    a = 1
b = *
    c = 2
end

I guess this was introduced in JuliaLang/julia#15156. Not sure this can be fixed without a full parser though...

[tpapp]

I have a fix for this, which I will submit once #37 is merged.

[non-Jedi]

@tpapp did you ever submit this fix?

[tpapp]

No. I have a branch which is severely outdated and provides a partial fix, if no one wants to take it up I will do it if #87 is merged.

[ronisbr]

Sorry about the dup.

To solve this, can’t we just check if the line stars with import here:

julia-emacs/julia-mode.el

Line 508 in 839726a

(defun julia-indent-hanging ()

[yuyichao]

Note that the title is not completely accurate. It also applies to the b = * case, as shown in the example. Basically any time when an operator is used not as an operator.

[ronisbr]

Hum, I see. However, since the case:

import Base: *

should be way more common than the other, can we implement this temporary fix until we have a full parser?

EDIT: By the way, am I missing something, or the second case will always happen if an operator appears after a =? Is there any other case that an operator can hang at the end of line without being an operation that did not end?

If I am right, then we can add two checks to that function: if the line started with import or if the operator is preceded by =, then the operator is not hanging.

[ronisbr]

I gave a try to solve it, but now I understand why we need a full parser. The indentation of lines after an import is treated here:

julia-emacs/julia-mode.el

Line 543 in 839726a

(defun julia-indent-import-export-using ()

instead of the previous function I marked. However, it does not seem easy to separate the code that mark a code line “unfinished” with that code that search for continuation in import. At least in my elisp level.

[ronisbr]

This issue is not present in tree-sitter implementation:

module A
import Base: *
a = 1
b = *
c = 2
end