Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping in julia-in-string docstring #181

Merged
merged 1 commit into from Jan 19, 2023
Merged

Fix escaping in julia-in-string docstring #181

merged 1 commit into from Jan 19, 2023

Conversation

ronisbr
Copy link
Contributor

@ronisbr ronisbr commented Jan 16, 2023

Hi!

Before this commit, the docstring of julia-in-string was rendered as:

Captura de Tela 2023-01-16 às 14 51 52

After, it is rendered as:

Captura de Tela 2023-01-16 às 14 52 26

This commit also suppresses a warning in Emacs 29 related to unescaped ':

NEWS from Emacs 29

*** Byte compilation will now warn about some quoting mistakes in docstrings.
When writing code snippets that contains the "'" character (APOSTROPHE),
that quote character has to be escaped to avoid Emacs displaying it as
"’" (LEFT SINGLE QUOTATION MARK), which would make code examples like>

(setq foo '(1 2 3))

invalid. Emacs will now warn during byte compilation if it seems
something like that, and also warn about when using RIGHT/LEFT SINGLE
QUOTATION MARK directly. In both these cases, if these characters
should really be present in the docstring, they should be quoted with
"=".

Closes #180

@ronisbr
Copy link
Contributor Author

ronisbr commented Jan 16, 2023

I am pretty sure the errors are not related with this commit.

@ronisbr
Copy link
Contributor Author

ronisbr commented Jan 19, 2023

Bump! :)

Copy link
Collaborator

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tpapp tpapp merged commit 7aafa8e into JuliaEditorSupport:master Jan 19, 2023
@ronisbr
Copy link
Contributor Author

ronisbr commented Jan 19, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning in Emacs 29
3 participants