Skip to content

Conversation

@tkf
Copy link
Member

@tkf tkf commented Sep 6, 2020

Fix #42 by updating to JuliaFolds/Transducers.jl#417

Using commit:
Fix performance regression with BlockArrays
JuliaFolds/Transducers.jl@a05477d
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files           4        4           
  Lines         427      427           
=======================================
  Hits          410      410           
  Misses         17       17           
Flag Coverage Δ
#unittests 96.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4aa6db...fdbcbea. Read the comment docs.

@tkf
Copy link
Member Author

tkf commented Sep 6, 2020

ID time ratio memory ratio
["parallel_triangular_sum", "sequential"] 0.20 (5%) ✅ 0.89 (1%) ✅
["parallel_triangular_sum", "threaded"] 0.21 (5%) ✅ 0.89 (1%) ✅
["parallel_triangular_sum", "threaded_nest", ":nestlevel => 1"] 0.22 (5%) ✅ 0.89 (1%) ✅
["parallel_triangular_sum", "threaded_nest", ":nestlevel => 2"] 0.26 (5%) ✅ 0.90 (1%) ✅
["parallel_triangular_sum", "threaded_nest", ":nestlevel => 3"] 0.33 (5%) ✅ 0.90 (1%) ✅
["sum", ":label => \"BlockVector\"", ":impl => \"floop\""] 0.04 (5%) ✅ 0.00 (1%) ✅
["sum", ":label => \"filter\"", ":impl => \"floop\""] 0.90 (5%) ✅ 1.00 (1%)
["sum", ":label => \"flatten\"", ":impl => \"for\""] 1.05 (5%) ❌ 1.00 (1%)

https://github.com/JuliaFolds/FLoops-data/blob/benchmark-results/2020/09/06/063739/result.md

@mergify mergify bot merged commit 53c7a4a into master Sep 6, 2020
@mergify mergify bot deleted the fix-blockarray-perf branch September 6, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance regression

2 participants