Improve compilation latency by reducing recursion limit #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative fix to #412.
Compilation benchmark using the example in #412:
FOLDL_RECURSION_LIMITFOLDL_RECURSION_LIMIT = Val(0)slows down["teerf_filter", "noinit"](and speedups["filter_sum", "1000", "RandomFloats", "noinit", "base"]):Interestingly,
FOLDL_RECURSION_LIMIT = Val(1)improves the performance:Re:
["filter_sum", "1000", "RandomFloats", "noinit", "base"], see #403.Commit Message
Improve compilation latency by reducing recursion limit (#412)
The tail-call pattern introduced in eb430cf
(#403) for linear indexing arrays seem to invoke a large compiler
latency (see #412 for an example). This patch tries to mitigate the
problem by reducing the
FOLDL_RECURSION_LIMITto 1. This stillallows two recursive calls. All the benchmarks do not show
noticeable degradation (presumably because recursion deeper than this
is not exercised in the benchmarks). Note that setting it to 0 (one
recursive call) shows 2x slowdown in
["teerf_filter", "noinit"]benchmark.