-
Notifications
You must be signed in to change notification settings - Fork 61
Add MIOpen #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MIOpen #320
Conversation
- DEBUG env variables no longer seems to be necessary... :/ - Update test
|
At this moment it supports:
For other types I get errors that look like either misconfigured |
|
@jpsamaroo not sure what to do about CI. To fix buildkite CI we can delete |
jpsamaroo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! My major requests are:
- Implementing locking around global data access
- Removing
get_prefixes
- Use NNlib for convolution comparisons. - Add LockedObject that manages resource's lock state. - Add MIOpen compat. - Remove 'get_' prefixes.
|
In case you haven't seen it already, the CUDA.CUDNN readme may be useful for discussions on function naming. That and the test code in the subpackage. |
- Move LockedObject from MIOpen to AMDGPU so that other stuff can use it.
No I haven't seen that, thanks. |
|
Regarding the error in CI: I dont have it on gfx1031. |
jpsamaroo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Co-authored-by: Julian Samaroo <jpsamaroo@jpsamaroo.me>
…pxl-th/add-miopen-wrapper
This PR adds initial support for MIOpen.
Mainly it will target only convolutions for now.
Example of convolution API:
TODO
MIOPEN_DEBUG_CONV_DIRECT_NAIVE_CONV_FWD=0,MIOPEN_DEBUG_CONV_DIRECT_NAIVE_CONV_BWD=0,MIOPEN_DEBUG_CONV_DIRECT_NAIVE_CONV_WRW=0.Potential fix is to rebuild HIP (hipamd) with PCH
on.UPD: Should be fixed with this PR: Disable PCH completely for MIOpen JuliaPackaging/Yggdrasil#5797
Code to generate MIOpen wrapper using Clang.jl