Skip to content

Conversation

@Red-Portal
Copy link
Contributor

This implements a few of the triangular-triangular multiplications by invoking trmm!, which addresses #1486

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1538 (9a40a20) into master (29afec2) will decrease coverage by 0.59%.
The diff coverage is 100.00%.

❗ Current head 9a40a20 differs from pull request most recent head c9e6b3d. Consider uploading reports for the commit c9e6b3d to get more accurate results

@@            Coverage Diff             @@
##           master    #1538      +/-   ##
==========================================
- Coverage   73.64%   73.05%   -0.60%     
==========================================
  Files         131      131              
  Lines        9859     9882      +23     
==========================================
- Hits         7261     7219      -42     
- Misses       2598     2663      +65     
Impacted Files Coverage Δ
lib/cublas/linalg.jl 83.03% <100.00%> (+2.03%) ⬆️
lib/cudnn/CUDNN.jl 37.50% <0.00%> (-35.94%) ⬇️
lib/cublas/CUBLAS.jl 50.44% <0.00%> (-25.67%) ⬇️
src/utilities.jl 68.91% <0.00%> (-4.06%) ⬇️
lib/cudadrv/CUDAdrv.jl 81.66% <0.00%> (-3.34%) ⬇️
lib/cudadrv/module/linker.jl 68.75% <0.00%> (-3.13%) ⬇️
lib/cudadrv/state.jl 77.84% <0.00%> (-2.28%) ⬇️
lib/cudadrv/error.jl 88.57% <0.00%> (-2.06%) ⬇️
lib/cudadrv/memory.jl 78.59% <0.00%> (-1.01%) ⬇️
lib/cusolver/linalg.jl 87.42% <0.00%> (+0.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29afec2...c9e6b3d. Read the comment docs.

@maleadt maleadt added enhancement New feature or request cuda array Stuff about CuArray. cuda libraries Stuff about CUDA library wrappers. labels Jun 8, 2022
@maleadt maleadt linked an issue Jun 8, 2022 that may be closed by this pull request
@maleadt maleadt merged commit 5efcee6 into JuliaGPU:master Jun 8, 2022
@Red-Portal
Copy link
Contributor Author

Great! Thanks for the quick review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda array Stuff about CuArray. cuda libraries Stuff about CUDA library wrappers. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CUBLAS: Multiplication of UpperTriangular/LowerTriangular not supported

2 participants