fixed gels_batched! issue #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also replaced the shallow copy in |
maleadt
added
bugfix
stillyslalom
reviewed
Jun 2, 2020
Contributor
stillyslalom
left a comment
stillyslalom
left a comment
There was a problem hiding this comment.
I made the error messages a bit more descriptive and changed inequality symbols to ASCII (a nitpick, but it's best practice to use ASCII for public-facing code given uneven support for Unicode on some platforms)
Improved error messaging and Unicode=>ASCII Co-authored-by: Alex Ames <alexander.m.ames@gmail.com>
Member
|
bors try |
Contributor
tryBuild succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, I believe there is a typo in the CUDA docs here https://docs.nvidia.com/cuda/cublas/index.html. Specifically, for the overdetermined system
Ax=C, the number of rows of C should equal the number of rows of A, not the number of columns.See https://discourse.julialang.org/t/accelerate-solving-many-matrix-problems/40500/7 for the use case and some details.
Second, I added a check to make sure that the arrays of matrices all have the same dimensions.
As an aside, I've never done a PR before, so hopefully it's not too atrocious.