Skip to content

Conversation

@maleadt
Copy link
Member

@maleadt maleadt commented Oct 5, 2020

Fixes #468, where a CuDevice was passed to a process which resulted in global state being accessed before any actual API call.

@maleadt maleadt added the bugfix This gets something working again. label Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #471 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
- Coverage   80.54%   80.50%   -0.05%     
==========================================
  Files         166      166              
  Lines        8852     8854       +2     
==========================================
- Hits         7130     7128       -2     
- Misses       1722     1726       +4     
Impacted Files Coverage Δ
src/initialization.jl 73.13% <100.00%> (ø)
src/state.jl 86.02% <100.00%> (+0.20%) ⬆️
lib/curand/random.jl 89.23% <0.00%> (-3.08%) ⬇️
lib/cublas/CUBLAS.jl 77.27% <0.00%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b83fc1b...ef457a0. Read the comment docs.

@maleadt maleadt merged commit 5ce8b7a into master Oct 5, 2020
@maleadt maleadt deleted the tb/multigpu_init branch October 5, 2020 09:19
maleadt added a commit that referenced this pull request Oct 5, 2020
Fix initialization of global state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This gets something working again.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when following example on using multiple GPUs on multiple processes

2 participants