New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flipkernel support and tests #181

Merged
merged 3 commits into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@tejank10
Copy link
Contributor

tejank10 commented Nov 1, 2018

flipkernel support for conv and related tests

@maleadt

This comment has been minimized.

Copy link
Member

maleadt commented Nov 3, 2018

Test failures seem related?

@tejank10

This comment has been minimized.

Copy link
Contributor

tejank10 commented Nov 3, 2018

Hmm, seems so. I just tested it again with NNlib master and they passed. Is it the one used for the checks?
EDIT: Okay, so it uses NNlib v0.4.2, which does not support flipkernel and crosscor.

@maleadt

This comment has been minimized.

Copy link
Member

maleadt commented Nov 4, 2018

Then you should add version bounds, and you can add NNLib to the list of packages that need to be checked-out from master in runtests.jl.

@maleadt maleadt force-pushed the tejank10:flipkernel branch from 0f4face to cd4cc7f Nov 5, 2018

@maleadt

This comment has been minimized.

Copy link
Member

maleadt commented Nov 5, 2018

bors try

bors bot added a commit that referenced this pull request Nov 5, 2018

@JuliaGPU JuliaGPU deleted a comment from bors bot Nov 5, 2018

@maleadt

This comment has been minimized.

Copy link
Member

maleadt commented Nov 5, 2018

Removed comment by bors was a try time-out (see https://forum.bors.tech/t/usage-with-gitlab-ci/245).

@maleadt

This comment has been minimized.

Copy link
Member

maleadt commented Nov 6, 2018

Please don't merge branches like that, especially not your own...
You can git pull --rebase if there's upstream changes.
Also, why check-out NNLib from master specifically, and not match like the lines right before?
I'll push an update to your branch if you don't mind.

@maleadt maleadt force-pushed the tejank10:flipkernel branch from f356af0 to 2a5c89f Nov 6, 2018

@maleadt

This comment has been minimized.

Copy link
Member

maleadt commented Nov 6, 2018

bors try

bors bot added a commit that referenced this pull request Nov 6, 2018

@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Nov 6, 2018

try

Build succeeded

@maleadt

This comment has been minimized.

Copy link
Member

maleadt commented Nov 6, 2018

Great, thanks!

@maleadt maleadt merged commit e8f9120 into JuliaGPU:master Nov 6, 2018

@tejank10

This comment has been minimized.

Copy link
Contributor

tejank10 commented Nov 6, 2018

Thanks for the changes Tim, I'll take care of the rebase in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment