From a0f9a271e04aa4bb08ff3dec8aacdebf8f5149c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ludovic=20R=C3=A4ss?= <61313342+luraess@users.noreply.github.com> Date: Wed, 19 Nov 2025 13:47:00 +0100 Subject: [PATCH 1/9] Add AMDGPU.jl job to Buildkite pipeline --- .buildkite/pipeline.yml | 47 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index 18505d556..30b5b9ab5 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -45,6 +45,53 @@ steps: soft_fail: - exit_status: 3 +- label: "AMDGPU.jl" + plugins: + - JuliaCI/julia#v1: + version: "1.10" + - JuliaCI/julia-coverage#v1: + codecov: true + command: | + julia -e 'using Pkg + + gpuarrays = pwd() + gpuarrayscore = joinpath(gpuarrays, "lib", "GPUArraysCore") + devdir = mktempdir() + package = joinpath(devdir, "AMDPU") + + println("--- :julia: Installing TestEnv") + Pkg.activate(; temp=true) + Pkg.add("TestEnv") + using TestEnv + + println("--- :julia: Installing AMDGPU.jl") + withenv("JULIA_PKG_PRECOMPILE_AUTO" => 0, + "JULIA_PKG_DEVDIR" => devdir) do + Pkg.develop("AMDGPU") + Pkg.activate(package) + + try + Pkg.develop([PackageSpec(path=gpuarrays), PackageSpec(path=gpuarrayscore)]) + TestEnv.activate() + catch err + @error "Could not install AMDGPU.jl" exception=(err,catch_backtrace()) + exit(3) + finally + Pkg.activate(package) + end + end + + println("+++ :julia: Running tests") + Pkg.test(; coverage=true)' + agents: + queue: "juliagpu" + rocm: "*" + rocmgpu: "*" + if: build.message !~ /\[skip tests\]/ + timeout_in_minutes: 120 + soft_fail: + - exit_status: 3 + - label: "oneAPI.jl" plugins: - JuliaCI/julia#v1: From 6372c66f496d9d4ad943655f7c4b5be40f73e769 Mon Sep 17 00:00:00 2001 From: Ludovic Raess Date: Wed, 19 Nov 2025 13:52:17 +0100 Subject: [PATCH 2/9] Fix ident --- .buildkite/pipeline.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index 30b5b9ab5..18ea80d08 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -45,7 +45,7 @@ steps: soft_fail: - exit_status: 3 -- label: "AMDGPU.jl" + - label: "AMDGPU.jl" plugins: - JuliaCI/julia#v1: version: "1.10" From c04faed35db7dad53b5f321b8d5aa2d73c0ec3bc Mon Sep 17 00:00:00 2001 From: Ludovic Raess Date: Wed, 19 Nov 2025 15:26:34 +0100 Subject: [PATCH 3/9] Fix typo --- .buildkite/pipeline.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index 18ea80d08..d943119b3 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -57,7 +57,7 @@ steps: gpuarrays = pwd() gpuarrayscore = joinpath(gpuarrays, "lib", "GPUArraysCore") devdir = mktempdir() - package = joinpath(devdir, "AMDPU") + package = joinpath(devdir, "AMDGPU") println("--- :julia: Installing TestEnv") Pkg.activate(; temp=true) From 9cd9daa558ec1418308863c8f36987f1ae850e9b Mon Sep 17 00:00:00 2001 From: Ludovic Raess Date: Wed, 19 Nov 2025 16:56:16 +0100 Subject: [PATCH 4/9] Try to only test gpuarrays from AMDGPU test suite --- .buildkite/pipeline.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index d943119b3..baf9594cf 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -82,7 +82,7 @@ steps: end println("+++ :julia: Running tests") - Pkg.test(; coverage=true)' + Pkg.test(; test_args=["gpuarrays"], coverage=true) agents: queue: "juliagpu" rocm: "*" From 9b8c834ccf75a40afef91db30f43e4cbee9e57f4 Mon Sep 17 00:00:00 2001 From: Ludovic Raess Date: Wed, 19 Nov 2025 16:59:40 +0100 Subject: [PATCH 5/9] Fix Typo --- .buildkite/pipeline.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index baf9594cf..9998d1b29 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -82,7 +82,7 @@ steps: end println("+++ :julia: Running tests") - Pkg.test(; test_args=["gpuarrays"], coverage=true) + Pkg.test(; test_args=["gpuarrays"], coverage=true)' agents: queue: "juliagpu" rocm: "*" From 447b09d8314a45eafd092306bd9f2f94f0152292 Mon Sep 17 00:00:00 2001 From: Ludovic Raess Date: Wed, 19 Nov 2025 21:56:17 +0100 Subject: [PATCH 6/9] Remove trailing white space --- test/testsuite/linalg.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/testsuite/linalg.jl b/test/testsuite/linalg.jl index 804912d82..cfc8c44cd 100644 --- a/test/testsuite/linalg.jl +++ b/test/testsuite/linalg.jl @@ -1,4 +1,4 @@ -@testsuite "linalg/core " (AT, eltypes)->begin +@testsuite "linalg/core" (AT, eltypes)->begin @testset "adjoint and transpose" begin @test compare(adjoint, AT, rand(Float32, 32, 32)) @test compare(adjoint!, AT, rand(Float32, 32, 32), rand(Float32, 32, 32)) From dae7bb99a41c43644996345bf538a8a04af1b127 Mon Sep 17 00:00:00 2001 From: Ludovic Raess Date: Wed, 19 Nov 2025 22:13:30 +0100 Subject: [PATCH 7/9] Test on rev branch --- .buildkite/pipeline.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index 9998d1b29..970434b53 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -67,7 +67,8 @@ steps: println("--- :julia: Installing AMDGPU.jl") withenv("JULIA_PKG_PRECOMPILE_AUTO" => 0, "JULIA_PKG_DEVDIR" => devdir) do - Pkg.develop("AMDGPU") + # Pkg.develop("AMDGPU") + Pkg.add(url="https://github.com/JuliaGPU/AMDGPU.jl", rev="lr/gpuarrays") Pkg.activate(package) try @@ -82,7 +83,7 @@ steps: end println("+++ :julia: Running tests") - Pkg.test(; test_args=["gpuarrays"], coverage=true)' + Pkg.test(; coverage=true)' agents: queue: "juliagpu" rocm: "*" From 0854fa086baf927a67f00596f8748ccb55c83166 Mon Sep 17 00:00:00 2001 From: Ludovic Raess Date: Thu, 20 Nov 2025 09:16:13 +0100 Subject: [PATCH 8/9] Format --- test/testsuite/linalg.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/testsuite/linalg.jl b/test/testsuite/linalg.jl index cfc8c44cd..c0e5f75b1 100644 --- a/test/testsuite/linalg.jl +++ b/test/testsuite/linalg.jl @@ -1,4 +1,4 @@ -@testsuite "linalg/core" (AT, eltypes)->begin +@testsuite "linalg/core" (AT, eltypes) -> begin @testset "adjoint and transpose" begin @test compare(adjoint, AT, rand(Float32, 32, 32)) @test compare(adjoint!, AT, rand(Float32, 32, 32), rand(Float32, 32, 32)) From 78da8c6267e0f6c7af971269cc34a5145307cbde Mon Sep 17 00:00:00 2001 From: Ludovic Raess Date: Thu, 20 Nov 2025 09:16:22 +0100 Subject: [PATCH 9/9] Revert --- .buildkite/pipeline.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml index 970434b53..d943119b3 100644 --- a/.buildkite/pipeline.yml +++ b/.buildkite/pipeline.yml @@ -67,8 +67,7 @@ steps: println("--- :julia: Installing AMDGPU.jl") withenv("JULIA_PKG_PRECOMPILE_AUTO" => 0, "JULIA_PKG_DEVDIR" => devdir) do - # Pkg.develop("AMDGPU") - Pkg.add(url="https://github.com/JuliaGPU/AMDGPU.jl", rev="lr/gpuarrays") + Pkg.develop("AMDGPU") Pkg.activate(package) try