-
Notifications
You must be signed in to change notification settings - Fork 58
SPIR-V target #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPIR-V target #10
Conversation
3da67a3 to
8d12bdd
Compare
|
What should we do with backend-specific JLLs? They aren't terribly big, the translator is 1MB while the tools are about 10MB, but they currently are slightly annoying in that they "break" LLVM assert builds (incompatible libLLVMs) and "break" shipping a Manifest (since separate versions are required for each version of Julia). |
|
Could the JLL be installed dynamically during the first creation of a SPIR-V target/job? That might prevent it from interfering with other backends. |
Xompute nodes typically don't have networking, and doing so outside of Pkg and Project.toml entries breaks semver. Another case for conditional dependencies, I guess... Maybe lazy artifacts? But then we still have the version dependency /Manifest issue, and that also downloads at run time (but at least makes it easier to do so eagerly too). |
With this, we don't directly depend on SPIRV JLLs, keeping GPUCompiler lightweight for other users (and sidestepping LLVM compatibility issues).
636f2b3 to
0c52482
Compare
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
- Coverage 61.02% 60.53% -0.50%
==========================================
Files 25 28 +3
Lines 1442 1495 +53
==========================================
+ Hits 880 905 +25
- Misses 562 590 +28
Continue to review full report at Codecov.
|
|
Made the JLL dependencies optional, but since they only work on LLVM 8 I ditched the Julia 1.3 compatibility. @jpsamaroo that means there's no GCN CI at all right now, we ought to fix that. |
No description provided.