Skip to content

Conversation

@maleadt
Copy link
Member

@maleadt maleadt commented Apr 23, 2020

No description provided.

@maleadt maleadt force-pushed the tb/spirv branch 3 times, most recently from 3da67a3 to 8d12bdd Compare May 28, 2020 09:35
@maleadt
Copy link
Member Author

maleadt commented May 28, 2020

What should we do with backend-specific JLLs? They aren't terribly big, the translator is 1MB while the tools are about 10MB, but they currently are slightly annoying in that they "break" LLVM assert builds (incompatible libLLVMs) and "break" shipping a Manifest (since separate versions are required for each version of Julia).

@jpsamaroo
Copy link
Member

Could the JLL be installed dynamically during the first creation of a SPIR-V target/job? That might prevent it from interfering with other backends.

@maleadt
Copy link
Member Author

maleadt commented May 28, 2020

Could the JLL be installed dynamically during the first creation of a SPIR-V target/job? That might prevent it from interfering with other backends.

Xompute nodes typically don't have networking, and doing so outside of Pkg and Project.toml entries breaks semver. Another case for conditional dependencies, I guess...

Maybe lazy artifacts? But then we still have the version dependency /Manifest issue, and that also downloads at run time (but at least makes it easier to do so eagerly too).

maleadt added 4 commits July 2, 2020 11:18
With this, we don't directly depend on SPIRV JLLs, keeping GPUCompiler lightweight
for other users (and sidestepping LLVM compatibility issues).
@maleadt maleadt force-pushed the tb/spirv branch 4 times, most recently from 636f2b3 to 0c52482 Compare July 2, 2020 10:09
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #10 into master will decrease coverage by 0.49%.
The diff coverage is 54.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   61.02%   60.53%   -0.50%     
==========================================
  Files          25       28       +3     
  Lines        1442     1495      +53     
==========================================
+ Hits          880      905      +25     
- Misses        562      590      +28     
Impacted Files Coverage Δ
src/GPUCompiler.jl 100.00% <ø> (ø)
src/utils.jl 23.07% <16.66%> (-5.50%) ⬇️
src/spirv.jl 55.26% <55.26%> (ø)
test/spirv.jl 66.66% <66.66%> (ø)
test/definitions/spirv.jl 83.33% <83.33%> (ø)
src/runtime.jl 64.91% <0.00%> (-3.51%) ⬇️
src/validation.jl 90.15% <0.00%> (-0.76%) ⬇️
src/irgen.jl 87.21% <0.00%> (-0.38%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f52ff6...a2b2fa1. Read the comment docs.

@maleadt
Copy link
Member Author

maleadt commented Jul 2, 2020

Made the JLL dependencies optional, but since they only work on LLVM 8 I ditched the Julia 1.3 compatibility. @jpsamaroo that means there's no GCN CI at all right now, we ought to fix that.

@maleadt maleadt marked this pull request as ready for review July 2, 2020 10:40
@maleadt maleadt merged commit 9ad3aa1 into master Jul 2, 2020
@maleadt maleadt deleted the tb/spirv branch July 2, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants