Excise Cassette #288
Merged
Excise Cassette #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leios
reviewed
Feb 9, 2022
Contributor
|
I just tested and this fixes #286, |
Co-authored-by: James Schloss <jrs.schloss@gmail.com>
This reverts commit 10573cf.
Member
Author
|
Depends on JuliaGPU/AMDGPU.jl#187 |
Member
Author
|
Ok CI seems to be since we need, JuliaGPU/CUDA.jl#1361 |
Merged
jpsamaroo
reviewed
Feb 16, 2022
Co-authored-by: Julian Samaroo <jpsamaroo@jpsamaroo.me>
Member
Author
|
So at this point the only failure besides KernelGradient is |
Member
|
Final failure should be fixed by: JuliaGPU/AMDGPU.jl#196 |
jpsamaroo
reviewed
Feb 19, 2022
jpsamaroo
reviewed
Feb 19, 2022
Co-authored-by: Julian Samaroo <jpsamaroo@jpsamaroo.me>
Member
|
The reflection failures are the same as for CUDAKernels. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.