Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Conversation

@findmyway
Copy link

I also added a github action to upload the generated docker images. Feel free to adjust it as necessary.

Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need more changes than this, e.g., updating Julia in the Dockerfile to match the manifest, updating the preferences (version=local changed to local=true + version=...), etc.

@findmyway findmyway requested a review from maleadt December 18, 2024 04:55
@findmyway
Copy link
Author

updating Julia in the Dockerfile to match the manifest

I'm very sure about this point. The Julia version is specified through docker build arguments. To make the Manifest.toml compatible with Julia version. I added an extra Manifest-v1.11.toml based on the doc here https://pkgdocs.julialang.org/v1/toml-files/#Different-Manifests-for-Different-Julia-versions

Feel free to suggest more improvements.

@@ -1,2 +1,3 @@
[CUDA_Runtime_jll]
version = "local"
__clear__ = ["version"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the clear?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is auto generated?

TBH, I'm not sure how to set the version here.

@maleadt
Copy link
Member

maleadt commented Dec 18, 2024

Alternative, we could get rid of the Manifest altogether and simply use compat bounds. That would make the arg the single point of truth. I can take a look if you want (or feel free to experiment yourself).

@maleadt
Copy link
Member

maleadt commented Dec 19, 2024

I've opted to fold these improvements into the existing Dockerfile of the CUDA.jl repository: JuliaGPU/CUDA.jl@6f9bcaa

You can now pull the dev tag from ghcr.io, and I'll built v5.5.2 too as the latest stable tag: https://github.com/JuliaGPU/CUDA.jl/pkgs/container/cuda.jl

@maleadt maleadt closed this Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants