[sd/geometrybasics] Simplify Polygon code and add tests #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test cases are adapted from
this file in pyshp (commit e5407f38c571029721d7aaa9cabca2aa7ecd9019)
The main tests are shown below.
Right now the tests are in a Pluto notebook. If desired I can adapt the notebook to make it includable from
runtests.jl
(with or without the plots).This addresses the first part of #39 (comment)
cc @SimonDanisch @Sov-trotter