Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[WIP] Dual Contours #26
Hey @sjkelly sorry I dropped the ball on this. Would a code review still be helpful?
Also, I wonder if you're seeing a difference between the results on 1.0 and 1.1 due to some additional SIMD optimizations. We had a similar issue in EnhancedGJK.jl where the dot product of vectors from StaticArrays could give infinitesimally different results on different Julia versions because SIMD was used in some versions and not others. As long as the difference in the resulting mesh is small (presumably it should be), then it should be OK.
I appreciate you pointing me in the right direction. There are several dot products here. I need to setup a 1.0 environment so I can get a full diff.
I am waiting to merge this until I have setup a system for differentiable geometry in my solid modelling kernel to get some additional testing. The algorithm is also very sub-optimal since it is a port from a python example. I will ping you after I do more cleanup.