-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put formal tests (Aqua, JET, JuliaFormatter) inside the main test set #330
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 115 115
Lines 6789 6789
=======================================
Hits 6605 6605
Misses 184 184 ☔ View full report in Codecov by Sentry. |
This makes sense to me. But why is there now also a broken doctest? |
where do you see that? the tests are passing on 1.10, aren't they? |
I meant, during the nightly run we see now Documenter failing (although I don't understand why) - It is very much possible that this would have already been the case before but it was hidden because the test would not run further than JET. |
I think that is due to unstable RNGs between Julia versions, which is why doctests should probably use StableRNGs.jl. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah sure
thanks! |
Upside: CI does not terminate if the code fails Aqua / JET / JuliaFormatter / Documenter tests, and can run the test suite until the end to detect other errors
Downside: the full test suite will always be run, including when JET can guarantee something will go wrong