Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put formal tests (Aqua, JET, JuliaFormatter) inside the main test set #330

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Jan 29, 2024

Upside: CI does not terminate if the code fails Aqua / JET / JuliaFormatter / Documenter tests, and can run the test suite until the end to detect other errors
Downside: the full test suite will always be run, including when JET can guarantee something will go wrong

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1ea44e) 97.28% compared to head (f0d3c17) 97.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         115      115           
  Lines        6789     6789           
=======================================
  Hits         6605     6605           
  Misses        184      184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonschoelly
Copy link
Contributor

This makes sense to me. But why is there now also a broken doctest?

@gdalle
Copy link
Member Author

gdalle commented Feb 11, 2024

where do you see that? the tests are passing on 1.10, aren't they?

@simonschoelly
Copy link
Contributor

I meant, during the nightly run we see now Documenter failing (although I don't understand why) - It is very much possible that this would have already been the case before but it was hidden because the test would not run further than JET.

@gdalle
Copy link
Member Author

gdalle commented Feb 12, 2024

I think that is due to unstable RNGs between Julia versions, which is why doctests should probably use StableRNGs.jl.
One more argument for merging this, if you approve the PR? I just opened #341 to keep track of the doctest issue

Copy link
Contributor

@simonschoelly simonschoelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah sure

@gdalle gdalle merged commit 34743a5 into master Feb 12, 2024
9 of 12 checks passed
@gdalle
Copy link
Member Author

gdalle commented Feb 12, 2024

thanks!

@gdalle gdalle deleted the gd/one_testset branch February 12, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants