Allow Dict to set prop indices #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdalle
requested changes
Nov 15, 2022
JuliaGraphs#29 Added a new function `index_available` to check if a property-value is valid
filchristou
force-pushed
the
fixIssue29
branch
from
b6f355e to
fd1ee3f
Compare
gdalle
reviewed
Jan 12, 2023
Member
gdalle
left a comment
gdalle
left a comment
There was a problem hiding this comment.
I approve these changes but I'm just wondering what kind of version bump this warrants: minor or patch?
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 98.67% 98.69% +0.02%
==========================================
Files 5 5
Lines 376 382 +6
==========================================
+ Hits 371 377 +6
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
I would say it's a patch, since it fixes what actually is a bug as described here. The new function |
gdalle
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #29.
Added a new function
index_availableto check if a property-value is valid.Added some relative tests.