Skip to content

Conversation

@ianna
Copy link
Member

@ianna ianna commented Jun 10, 2024

Note: Changes in Julia nightly builds:

  • The type of error thrown when trying to access a non-existent field in a NamedTuple in Julia has changed to FieldError.

@ianna ianna marked this pull request as draft June 10, 2024 14:42
@codecov
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 96.26168% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.91%. Comparing base (3993678) to head (59e803d).

Files Patch % Lines
src/form_utils.jl 96.26% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   75.69%   76.91%   +1.22%     
==========================================
  Files           4        5       +1     
  Lines        1691     1798     +107     
==========================================
+ Hits         1280     1383     +103     
- Misses        411      415       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible use-cases:

  • get a RecordArray form for selected branches
  • get a RecordArray form for a full tree

Question: how to assign the node indices?

@ianna ianna marked this pull request as ready for review June 14, 2024 15:22
@ianna ianna requested a review from Moelf June 14, 2024 15:22
@ianna ianna merged commit 96c45c4 into main Jun 14, 2024
@ianna ianna deleted the ianna/form_utils branch June 14, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants