-
Notifications
You must be signed in to change notification settings - Fork 2
fix: remove global constants #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* a helper to convert Julia Awkward array to Python
9e1ef67 to
66d193a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 71.32% 71.32%
=======================================
Files 3 3
Lines 1618 1618
=======================================
Hits 1154 1154
Misses 464 464 ☔ View full report in Codecov by Sentry. |
|
Instead of installing test dependency on the fly, it's cleaner to have a test Project.toml, for example: https://github.com/JuliaHEP/UnROOT.jl/blob/main/test/Project.toml . They will be installed in addition to the package you're testing |
I think, I'd like to have |
|
That's fine, you're doing the Pkg extension mechanism right? The test project.toml is the correct way to test that setup, basically that would simulate when user have AK.jk and PyCall.jl installed |
|
we can merge this and I can make a PR later to move to Pkg extension system |
It seems to me that creating global constants in the tests is unnecessary.
PyCallchecks if a Python package has been imported and reuses it.