remove eval in front of requires blocks

[KristofferC]

Having the @eval there makes the @require pattern matching for include fail and the pacakge thereby is unusuable when used together with PackageCompiler (example log: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/dd0c14b_vs_dd0c14b/YaoQX.primary.log)

┌ Warning: Error requiring `MPI` from `HDF5`
│   exception =
│    LoadError: SystemError: opening file "/home/pkgeval/.julia/packages/HDF5/pIJra/src/mpio.jl": No such file or directory
│    Stacktrace:
│      [1] systemerror(p::String, errno::Int32; extrainfo::Nothing)

[musm]

LGTM. The reason we used @eval here was to trigger precompilation as documented in the Requires.jl README https://github.com/JuliaPackaging/Requires.jl. Since that's not compatible with PackageCompiler, perhaps a PR to the Requires README documentation would be in order?

[musm]

Are there any solution that are compatible with both PackageCompiler and precompilation of the glue code using Requires?

[KristofferC]

I am confused. You aren't using a separate "glue" package here. You are just using include. @eval will have no influence here.

[musm]

Got it, I think there was misunderstanding of @eval when we added these in that case.