Skip to content

Conversation

@IanButterworth
Copy link
Member

Loading via FileIO/ImageIO in threaded loops doesn't appear to be threadsafe https://discourse.julialang.org/t/segfault-while-loading-images-in-multiple-threads/48878/10

This ensures that the checking and loading of PNGFiles is done sequentially, the cost of which is negligible

The execution time of the new checked_import

0.530126 seconds (893.98 k allocations: 64.787 MiB, 2.17% gc time, 18.76% compilation time)
  0.000001 seconds
  0.000001 seconds
  0.000001 seconds
  0.000001 seconds
  0.000001 seconds

The matching PR in FileIO: JuliaIO/FileIO.jl#276

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #11 into master will increase coverage by 19.04%.
The diff coverage is 68.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #11       +/-   ##
===========================================
+ Coverage   47.61%   66.66%   +19.04%     
===========================================
  Files           1        1               
  Lines          21       21               
===========================================
+ Hits           10       14        +4     
+ Misses         11        7        -4     
Impacted Files Coverage Δ
src/ImageIO.jl 66.66% <68.75%> (+19.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e324f2...6c10c60. Read the comment docs.

@IanButterworth IanButterworth merged commit 96ce978 into master Oct 24, 2020
@IanButterworth IanButterworth deleted the ib/load_lock branch October 24, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants