Upgrade to Julia 1.3+, use JLL package for ImageMagick #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly simplify a few things as we can now directly specify what version of a dependency we support.
Co-Authored-By: Tim Holy <tim.holy@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
==========================================
- Coverage 71.12% 69.11% -2.02%
==========================================
Files 2 2
Lines 329 327 -2
==========================================
- Hits 234 226 -8
- Misses 95 101 +6
Continue to review full report at Codecov.
|
Member
|
We're failing on nightly on a couple of platforms, but since it works on 1.3 I say let's merge this! I might wait a day or so and see if we can fix nightly before registering a new version. Any reason not to call it 1.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly simplify a few things as we can now directly specify what version of a dependency we support.
This is, naturally, 1.3+ only, I'm using it to try and make the GtkArtifactTest repo 100% JLL package based.