Fails on 1.5

[KristofferC]

PkgEval indicates this package fails on the upcoming 1.5:

https://github.com/JuliaCI/NanosoldierReports/blob/680e2355355927aeac1c26154cc0aca38b5c13e6/pkgeval/by_hash/bf34e0a_vs_b5f13c3/logs/JLD2/1.5.0-beta1-c594048585.log

It's not clear exactly why.

[ctkelley]

Does JLD still work?

[JonasIsensee]

The error doesn't show up because the relevant test just does something like
@test success(`julia testscript.jl`)
where any output is sent to /dev/null.

Here's the actual error message:

Test threw exception
│   Expression: MyCustomLoad.load_my_object(my_object_filename)
│   syntax: invalid syntax (struct_type (outerref ##Main.Baz#254) #<julia: svec()> #<julia: svec(:x, :y, :z)> #<julia: Any> #<julia: svec(Int64, Int64, Int64)> (false) 0)
│   Stacktrace:
│    [1] handle_error(::ErrorException, ::FileIO.File{FileIO.DataFormat{:JLD2}}) at /home/jonas/.julia/packages/FileIO/ZknoK/src/error_handling.jl:82
│    [2] handle_exceptions(::Array{Any,1}, ::String) at /home/jonas/.julia/packages/FileIO/ZknoK/src/error_handling.jl:77
│    [3] load(::FileIO.Formatted; options::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at /home/jonas/.julia/packages/FileIO/ZknoK/src/loadsave.jl:186
│    [4] load at /home/jonas/.julia/packages/FileIO/ZknoK/src/loadsave.jl:166 [inlined]
│    [5] #load#13 at /home/jonas/.julia/packages/FileIO/ZknoK/src/loadsave.jl:118 [inlined]
│    [6] load at /home/jonas/.julia/packages/FileIO/ZknoK/src/loadsave.jl:118 [inlined]
│    [7] load_my_object(::String) at /tmp/jl_qQdyFl/mycustomload.jl:5
│    [8] (::var"#1#2")() at ./none:0
│    [9] with_logstate(::Function, ::Any) at ./logging.jl:408
│    [10] with_logger at ./logging.jl:514 [inlined]
│    [11] #collect_test_logs#45 at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.5/Test/src/logging.jl:51 [inlined]
│    [12] collect_test_logs at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.5/Test/src/logging.jl:50 [inlined]
│    [13] #match_logs#46 at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.5/Test/src/logging.jl:186 [inlined]
│    [14] match_logs(::Function, ::Tuple{Symbol,String}) at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.5/Test/src/logging.jl:186
│    [15] top-level scope at /tmp/jl_qQdyFl/loading.jl:7
│    [16] include(::Function, ::Module, ::String) at ./Base.jl:380
│    [17] include(::Module, ::String) at ./Base.jl:368
│    [18] exec_options(::Base.JLOptions) at ./client.jl:296
│    [19] _start() at ./client.jl:506

Here's a simpler way to reproduce the problem:

julia> struct A
       x::Int
       end

julia> a = A(1)
A(1)

julia> using JLD2

julia> @save "test.jld2" a

julia> using JLD2

julia> @load "test.jld2" a
┌ Warning: type Main.A does not exist in workspace; reconstructing
└ @ JLD2 ~/.julia/dev/JLD2/src/data.jl:1190
ERROR: syntax: invalid syntax (struct_type (outerref ##Main.A#254) #<julia: svec()> #<julia: svec(:x)> #<julia: Any> #<julia: svec(Int64)> (false) 0)
Stacktrace:
 [1] top-level scope at none:1
 [2] eval at ./boot.jl:331 [inlined]
 [3] reconstruct_compound(::JLD2.JLDFile{JLD2.MmapIO}, ::String, ::JLD2.CompoundDatatype, ::Array{JLD2.RelOffset,1}) at /home/jonas/.julia/dev/JLD2/src/data.jl:1222
 [4] constructrr(::JLD2.JLDFile{JLD2.MmapIO}, ::JLD2.UnknownType{String}, ::JLD2.CompoundDatatype, ::Array{JLD2.ReadAttribute,1}) at /home/jonas/.julia/dev/JLD2/src/data.jl:1191
 [5] jltype(::JLD2.JLDFile{JLD2.MmapIO}, ::JLD2.CommittedDatatype) at /home/jonas/.julia/dev/JLD2/src/data.jl:323
 [6] read_data(::JLD2.JLDFile{JLD2.MmapIO}, ::JLD2.ReadDataspace, ::UInt8, ::Int64, ::Int64, ::Int64, ::UInt16, ::JLD2.RelOffset, ::Array{JLD2.ReadAttribute,1}) at /home/jonas/.julia/dev/JLD2/src/datasets.jl:146
 [7] load_dataset(::JLD2.JLDFile{JLD2.MmapIO}, ::JLD2.RelOffset) at /home/jonas/.julia/dev/JLD2/src/datasets.jl:92
 [8] getindex(::JLD2.Group{JLD2.JLDFile{JLD2.MmapIO}}, ::String) at /home/jonas/.julia/dev/JLD2/src/groups.jl:108
 [9] read(::JLD2.JLDFile{JLD2.MmapIO}, ::String) at /home/jonas/.julia/dev/JLD2/src/JLD2.jl:326
 [10] #3 at /home/jonas/.julia/dev/JLD2/src/loadsave.jl:112 [inlined]
 [11] jldopen(::var"#3#4", ::String; kws::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}) at /home/jonas/.julia/dev/JLD2/src/loadsave.jl:4
 [12] jldopen(::Function, ::String) at /home/jonas/.julia/dev/JLD2/src/loadsave.jl:2
 [13] top-level scope at /home/jonas/.julia/dev/JLD2/src/loadsave.jl:111

[jaakkor2]

Looks like :struct_type was removed in JuliaLang/julia#33553 .

https://github.com/JuliaLang/julia/blob/d6d5208d66be637543232bec4b0c79b2811ea1c6/doc/src/devdocs/ast.md says
!!! compat "Julia 1.5" struct_type, abstract_type, and primitive_type were removed in Julia 1.5 and replaced by calls to new builtins.

[JonasIsensee]

Thank you @jaakkor2 !
I had looked for this but must have just read over that particular line.