use new instead of T() #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 90.57% 90.57% -0.01%
==========================================
Files 21 21
Lines 2420 2430 +10
==========================================
+ Hits 2192 2201 +9
- Misses 228 229 +1
Continue to review full report at Codecov.
|
|
Since this approach is already in use inside BSON and it passes all existing plus new tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.3.0introduced a bug in that functions can no longer be reconstructed. (#258)The offending thing was essentially to try
typeof(f)()to get the function from its type.With this change it seems to work but I have no absolutely no idea whether this is a good idea or not.
Any ideas or recommendations ?