round trip tests with functional values #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey ! |
Collaborator
|
Btw. have you by any chance tested this against |
Contributor
Author
|
Yes, all these tests pass against |
Collaborator
|
Great! (I merged this into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't have enough insight into whether #260 is a good idea or not, so instead I wrote some tests.
These tests round trip various objects containing a function value
f(issue #258.)On master, 8 fail, 2 pass.
On the
reconstructfunctionsbranch of PR #260, 2 fail:[f]and[f, f], though for some reason round tripping[f, 42]works just fine.For comparison, all of these tests pass for v0.2.4.