Accept any Tables.jl-compatible source to write_parquet #96
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Tables.jl interface is designed so consumers (i.e. `write_parquet`) should never call `Tables.rowaccess` or `Tables.columnaccess`; they just call whatever orientation they need the data in (in this case, `Tables.columns`), and Tables.jl will take care of the rest. Column-oriented sources will be "automatic", while row-oriented sources will have columns "built", so that either way, `write_parquet` will get columns to write out.
Member
Author
|
This came up from a discourse post discussion: https://discourse.julialang.org/t/struggling-to-implement-tables-jl-interface-for-vector-mystruct/42318/7?u=quinnj |
Contributor
|
Makes sense. I misunderstood Tables.jl. @tanmaykm owns this so he can approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tables.jl interface is designed so consumers (i.e.
write_parquet) should never callTables.rowaccessorTables.columnaccess; they just call whatever orientation they need the data in (in this case,Tables.columns), and Tables.jl will take care of the rest. Column-oriented sources will be "automatic", while row-oriented sources will have columns "built", so that either way,write_parquetwill get columns to write out.cc: @xiaodaigh @tanmaykm