Skip to content

Commit eb6459b

Browse files
committed
Allow unpacked repeated pritimites
1 parent 787898a commit eb6459b

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

src/codegen/encode_methods.jl

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,16 @@ function field_encode_expr(@nospecialize(f::FieldType), ctx::Context)
3030
!isempty(encoding_val_type) && (encoding_val_type = ", Val{$encoding_val_type}")
3131
# TODO: do we want to allow unpacked representation? Docs say that parsers must always handle both cases
3232
# and since packed is strictly more efficient, currently we don't allow that.
33-
# is_packed = parse(Bool, get(f.options, "packed", "false"))
34-
# if is_packed
33+
is_packed = parse(Bool, get(f.options, "packed", "false"))
34+
if is_packed
3535
return "PB.encode(e, $(string(f.number)), x.$(jl_fieldname(f))$(encoding_val_type))"
36-
# else
37-
# return """
38-
# for el in x.$(jl_fieldname(f))
39-
# PB.encode(e, $(string(f.number)), el$(encoding_val_type))
40-
# end"""
41-
# end
36+
else
37+
return """
38+
for el in x.$(jl_fieldname(f))
39+
PB.encode(e, $(string(f.number)), el$(encoding_val_type))
40+
end
41+
"""
42+
end
4243
else
4344
return _field_encode_expr(f, ctx)
4445
end

0 commit comments

Comments
 (0)