Skip to content

Conversation

@giordano
Copy link
Member

I have no idea what was the problem with snappy_jll 1.1.9, but tests pass for me on M1 (no less):

     Testing Running tests...
Test Summary:        | Pass  Total  Time
Low-level Interfaces |   54     54  0.1s
Test Summary:         | Pass  Total  Time
High-level Interfaces |  113    113  0.7s
     Testing Snappy tests passed

It'd be great to get a new version if/when this is merged.

@giordano
Copy link
Member Author

giordano commented Jun 24, 2022

Well, quite funny tests pass on a platform not tested in CI.

Edit: actually, macOS isn't tested at all here. And the only version of Windows is passing the tests.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #35 (d7cbcfe) into master (004edb5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   83.63%   83.63%           
=======================================
  Files           2        2           
  Lines          55       55           
=======================================
  Hits           46       46           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a5027...d7cbcfe. Read the comment docs.

@giordano
Copy link
Member Author

Failure #32 on Linux has been fixed by JuliaPackaging/Yggdrasil#5067 (which backported an upstream patch). This is working now. I'm taking the executive decision of merging this and tagging a new patch release, for the benefit of making this package usable on M1

@giordano giordano merged commit 015abed into JuliaIO:master Jun 25, 2022
@giordano giordano deleted the mg/new-jll branch June 25, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

package broken for large inputs

1 participant