Skip to content
This repository was archived by the owner on Oct 4, 2025. It is now read-only.

WIP: Fix source build for Julia 1.5 #466

Closed
wants to merge 27 commits into from
Closed

WIP: Fix source build for Julia 1.5 #466

wants to merge 27 commits into from

Conversation

@Gnimuc
Copy link
Member

@Gnimuc Gnimuc commented Mar 31, 2020

  • misc. updates for LLVM9
  • fix segfaults

Gnimuc added 27 commits March 25, 2020 17:55
@Gnimuc
Fix source build for Julia 1.4
3d4f6c2
@Gnimuc
Update source build patches
c525d15
@Gnimuc
Change ObjC1&ObjC2 to ObjC
5f574b9 
LLVM has no plan to support ObjC1 in the future, so this distinction is eliminated.
@Gnimuc
Fix EmitAggregateCopy
61e6367 
Not sure whether it is right to use `clang::CodeGen::AggValueSlot::DoesNotOverlap` here or not, the doc says it can help compiler to do optimizations.
@Gnimuc
Remove TypeContainsAuto flag for BuildCXXNew
145f48c
@Gnimuc
getLocStart -> getBeginLoc
cf7af64
@Gnimuc
llvm::MemoryBuffer->llvm::WritableMemoryBuffer
1dd2d67 
`getNewMemBuffer` for `llvm::MemoryBuffer` was removed in 322475.
@Gnimuc
clang::vfs -> llvm::vfs
c3c46ae
@Gnimuc
Use XXX::Create static methods instead of constructors
63d55ae
@Gnimuc
Fix ActOnFields's last argument
cf8f7ae
@Gnimuc
Clean up include
15e2064
@Gnimuc
Fix PrettyDeclStackTraceEntry ctor usage
626373a
@Gnimuc
clang::ParsedAttributes no longer has a getList() method
f29561a
@Gnimuc
Fix clang::DeclRefExpr ctor usage
87be408
@Gnimuc
Fix clang::ReturnStmt::Create's first argument
3d4ffa7
@Gnimuc
Remove new (&Cxx->CI->getASTContext())
2ee09ae 
Honestly, I don't know why this works.
@Gnimuc
Add missing clang libs
3a51008
@Gnimuc
Update patches and BuildBootstrap.Makefile
744fc8a 
There is no need to patch Clang source code in LLVM 9.0.1.
@Gnimuc
setLastStmt was removed in LLVM 9.0.1
b6dbff1
@Gnimuc
Fix LookupFile's last argument
a412bb2
@Gnimuc
Fix JuliaPCHGenerator
d0a36a3
@Gnimuc
VirtualFileSystem.h has been moved to llvm
ac6b4f0
@Gnimuc
Add back implementation of pushExternalDeclIntoScope which was remo…
a296a73 
…ved by `llvm-svn: 358538`
@Gnimuc
Minor argument fixes
383a1b3
@Gnimuc
Remove getOrInsertFunction, use Function::Create instead
9b2784d
@Gnimuc
fix-up
58f0b03
@Gnimuc
julia_type_to_llvm -> jl_type_to_llvm
0b8e414
@p-zubieta
Copy link

p-zubieta commented May 18, 2020

Can this be made to depend on Libffi_jll and LLVM_jll? Or are there custom patches that need to be applied?

@Gnimuc
Copy link
Member Author

Gnimuc commented May 19, 2020

Please refer to https://github.com/JuliaInterop/Cxx.jl/pull/466/files#diff-c002a594a18961699f1519658022b71e. Currently, it depends on LLVM_full_jll@9.

@p-zubieta
Copy link

p-zubieta commented May 19, 2020

Completely missed that. It will rely on Julia's LLVM since julia itself is now using that, right?

@Gnimuc
Copy link
Member Author

Gnimuc commented May 19, 2020

Yes. Both Cxx.jl and Julia rely on LLVM, but Cxx.jl needs Clang as well.

@Gnimuc
Copy link
Member Author

Gnimuc commented May 19, 2020 •
edited
Loading

This PR may only fix the C++ side of the package for now. As of the Julia side, it requires more knowledge about the Julia's and Clang's internals, I'm still learning the details and making nearly no progress.

@Gnimuc Gnimuc mentioned this pull request Sep 9, 2020
Open
@Gnimuc Gnimuc closed this Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gnimuc @p-zubieta