Refactor Contractor so that the call is a standard function call #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This seems to break pave -- when empty?
dpsanders
added a commit
that referenced
this pull request
Feb 5, 2017
* Refactor flatAST with methods * FlattenedAST -> FlatAST * forward_backward replaces forward_pass and backward_pass * Working NewContractor with action via function call * Make contractors in separators use new syntax (accepting IntervalBox. This seems to break pave -- when empty? * Finish rewrite to use forward_backward. Contractor call is messy. * Clean up functions * Clean up contractor code * Clean up separator code * Add for contractor call * Make contractors return IntervalBox'es and deal with fallout * Correct sqr_rev
dpsanders
added a commit
that referenced
this pull request
Feb 6, 2017
* Update examples (#42) * Delete some unnecessary files; update Annulus notebook * Basic separators notebook Remove example notebooks * README points to docs. Update NEWS for 0.4 (#43) * add FixedSizeArrays to REQUIRE (#24) if it's being used or imported, it should be depended on explicitly instead of assuming it will be present as an indirect dependency * Multi-dimensional functions (#44) * Parametrize Separators * Fix test * Fixes for the types of lhs and args * Multi-dimensional contractor seems to be working! * Make multidim iterated functions work * Remove debugging output for iterated functions * Move parse_comparison to separator.jl * Escape name of contractor when creating constraint so that it is available with name _C_1_ etc. * Convenience constructor for ConstraintSeparator that automatically extracts variables * Factor out content of into make_constraint function * Parametrise interval field of ConstraintSeparator * Refactor Contractor so that the call is a standard function call (#48) * Refactor flatAST with methods * FlattenedAST -> FlatAST * forward_backward replaces forward_pass and backward_pass * Working NewContractor with action via function call * Make contractors in separators use new syntax (accepting IntervalBox. This seems to break pave -- when empty? * Finish rewrite to use forward_backward. Contractor call is messy. * Clean up functions * Clean up contractor code * Clean up separator code * Add for contractor call * Make contractors return IntervalBox'es and deal with fallout * Correct sqr_rev * Unary minus, repeated addition, power_rev for odd powers (#49) * Make unary minus work * Make power_rev work with odd powers for intervals with negative regions * Split up repeated addition and multiplication. Needs test. * Add test for power_rev with odd power * Fix rebase * Update NEWS.md for 0.4 (#53) * Add back required version for FixedSizeArrays
dpsanders
added a commit
that referenced
this pull request
Feb 6, 2017
* Refactor flatAST with methods * FlattenedAST -> FlatAST * forward_backward replaces forward_pass and backward_pass * Working NewContractor with action via function call * Make contractors in separators use new syntax (accepting IntervalBox. This seems to break pave -- when empty? * Finish rewrite to use forward_backward. Contractor call is messy. * Clean up functions * Clean up contractor code * Clean up separator code * Add for contractor call * Make contractors return IntervalBox'es and deal with fallout * Correct sqr_rev
dpsanders
added a commit
that referenced
this pull request
Feb 6, 2017
* Refactor flatAST with methods * FlattenedAST -> FlatAST * forward_backward replaces forward_pass and backward_pass * Working NewContractor with action via function call * Make contractors in separators use new syntax (accepting IntervalBox. This seems to break pave -- when empty? * Finish rewrite to use forward_backward. Contractor call is messy. * Clean up functions * Clean up contractor code * Clean up separator code * Add for contractor call * Make contractors return IntervalBox'es and deal with fallout * Correct sqr_rev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.