Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Color uninstallable on julia 0.4 #105

Merged
merged 1 commit into from Oct 16, 2015
Merged

Make Color uninstallable on julia 0.4 #105

merged 1 commit into from Oct 16, 2015

Conversation

timholy
Copy link
Contributor

@timholy timholy commented Oct 13, 2015

It's deprecated in favor of Colors.

It's deprecated in favor of Colors
@timholy
Copy link
Contributor Author

timholy commented Oct 13, 2015

Assuming no objections here, once merged I'll tag a new release, then delete all older versions from METADATA.jl.

@tkelman
Copy link
Contributor

tkelman commented Oct 13, 2015

No, do not delete old versions. Adding the version ceiling to them should be okay though if there are no packages that still need to migrate.

timholy added a commit that referenced this pull request Oct 16, 2015
Make Color uninstallable on julia 0.4
@timholy timholy merged commit ab6ce2c into master Oct 16, 2015
@timholy timholy deleted the teh/deprecate branch October 16, 2015 10:14
@tkelman
Copy link
Contributor

tkelman commented Oct 16, 2015

Honestly a better approach would be doing this gently, throwing a deprecation warning for long enough that all dependent packages can be fixed. If the package is loadable and mostly functions, we don't need to be so forceful as to make packages uninstallable right away.

@timholy
Copy link
Contributor Author

timholy commented Oct 16, 2015

It's been throwing a deprecation warning ever since late August.

But people don't seem to like this. I can revert if you really want.

@tkelman
Copy link
Contributor

tkelman commented Oct 16, 2015

It's okay on master of the package but not ready for metadata yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants