Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Splat #785

Merged
merged 8 commits into from
Nov 29, 2022
Merged

add Splat #785

merged 8 commits into from
Nov 29, 2022

Conversation

MasonProtter
Copy link
Contributor

@codecov
Copy link

codecov bot commented Nov 17, 2022 •
edited
Loading

Codecov Report

Merging #785 (c885289) into master (abce98e) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   91.69%   91.86%   +0.16%     
==========================================
  Files           2        2              
  Lines         253      258       +5     
==========================================
+ Hits          232      237       +5     
  Misses         21       21
Impacted Files Coverage Δ
src/Compat.jl 92.40% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

martinholters
martinholters reviewed Nov 21, 2022
View reviewed changes
src/Compat.jl Outdated
@@ -616,6 +616,44 @@ if VERSION < v"1.9.0-DEV.1163"

_empty_stack(_...) = throw(ArgumentError("`stack` on an empty collection is not allowed"))
end

@static if !isdefined(Base, :Splat)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@static if !isdefined(Base, :Splat)
if VERSION < v"1.9.0-DEV.513"

To make it easier in the future to figure out at what point this can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but I think it's better to do it with a @static if.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why is that?

@Seelengrab Seelengrab mentioned this pull request Nov 27, 2022
Closed
@martinholters martinholters merged commit 295c146 into JuliaLang:master Nov 29, 2022
@MasonProtter MasonProtter deleted the patch-1 branch November 29, 2022 22:04
@mcabbott
Copy link
Contributor

After JuliaLang/julia#48038 this should probably export some lower-case splat function. Probably its own Compat.splat, not the existing Base.splat.

@martinholters
Copy link
Member

Ah, this is quite unfortunate. Un-exporting Splat would technically be breaking. So I guess we should just keep Splat and and add splat and change the documentation to only mention splat?

Probably its own Compat.splat, not the existing Base.splat.

And why is that?

@martinholters martinholters mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinholters martinholters martinholters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MasonProtter @mcabbott @martinholters