Pkg REPL mode broken in 1.11-rc4

[nilshg]

Already noticed this in rc3 but it's still a problem and I've just set up a completely new machine so could confirm that this happens on a fresh install (Windows 11, Julia 1.11-rc4 installed through Juliaup, then just add IJulia; using IJulia; notebook() and allowing the standard install of miniconda).

Then in a notebook I do:

] st

and get:

MethodError: no method matching do_cmd(::IJulia.MiniREPL, ::String; do_rethrow::Bool)
The function `do_cmd` exists, but no method is defined for this combination of argument types.

Closest candidates are:
  do_cmd(::Pkg.REPLMode.Command, ::Any) got unsupported keyword argument "do_rethrow"
   @ Pkg ...\.julia\juliaup\julia-1.11.0-rc4+0.x64.w64.mingw32\share\julia\stdlib\v1.11\Pkg\src\REPLMode\REPLMode.jl:398

I assume this is related to the excision of Pkg?

[nilshg]

Just to prevent things from getting slackholed, @mkitti identified that in this commit:

JuliaLang/Pkg.jl@12d2de1

the do_rethrow keyword of do_cmd got removed. He suggested potentially dropping the keyword at the call site:

IJulia.jl/src/execute_request.jl

Line 51 in 60568fa

escape_string(code[2:end]) * "\"; do_rethrow=true)"

I'm not familiar enough with the IJulia codebase to understand whether that's a good idea though!

[nilshg]

This is great, thanks - might this warrant a patch release?

[stevengj]

JuliaRegistries/General#118774