Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

remove use of is() #68

Merged
merged 3 commits into from Jan 17, 2017
Merged

remove use of is() #68

merged 3 commits into from Jan 17, 2017

Conversation

ZacLN
Copy link
Contributor

@ZacLN ZacLN commented Nov 28, 2016 •
edited

Fixes a few deprecated warnings on master.

@KristofferC
Copy link
Sponsor Member

lgtm

@ararslan ararslan mentioned this pull request Jan 15, 2017
Merged
@KristofferC KristofferC reopened this Jan 17, 2017
@KristofferC
Copy link
Sponsor Member

Looks like some dependencies got broken by the type PR in Base.

@KristofferC KristofferC merged commit 97f61f0 into JuliaLang:master Jan 17, 2017
@ZacLN ZacLN deleted the depfix branch January 17, 2017 13:51
@tkelman
Copy link
Contributor

tkelman commented Jan 17, 2017 •
edited

You should use Vector for these when you know they are 1 dimensional. Otherwise the compiler has to do the work to determine the N parameter.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KristofferC KristofferC KristofferC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ZacLN @KristofferC @tkelman