Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Tag CategoricalArrays.jl v0.2.0 #10987

Merged
merged 15 commits into from Sep 2, 2017

Conversation

attobot
Copy link
Contributor

@attobot attobot commented Aug 30, 2017

Repository: JuliaData/CategoricalArrays.jl
Release: v0.2.0
Diff: vs v0.1.6
requires vs v0.1.6:

--- 0.1.6/requires
+++ 0.2.0/requires
@@ -1,3 +1,3 @@
-julia 0.5.0
+julia 0.6-
 Compat 0.19.0
-NullableArrays
+Nulls 0.0.2

cc: @nalimilan

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@@ -0,0 +1,3 @@
julia 0.6-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you still need to support prereleases?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really care, will remove on CategoricalArrays master for next time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you use struct syntax, so 0.6- isn't valid since that includes very early prereleases of 0.6 where that syntax didn't work yet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've re-tagged the release and updated the PR.

@nalimilan
Copy link
Member

nalimilan commented Aug 30, 2017

This is based on #10969, shouldn't be merged before it because of probable observed conflicts.

@nalimilan
Copy link
Member

push this to your own fork please!

Sorry, I made a mistake when trying to update the Attobot branch.

@attobot
Copy link
Contributor Author

attobot commented Aug 30, 2017

Repository: JuliaData/CategoricalArrays.jl
Release: v0.2.0
Diff: vs v0.1.6
requires vs v0.1.6:

--- 0.1.6/requires
+++ 0.2.0/requires
@@ -1,3 +1,3 @@
-julia 0.5.0
+julia 0.6
 Compat 0.19.0
-NullableArrays
+Nulls 0.0.2

cc: @nalimilan

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@nalimilan nalimilan force-pushed the CategoricalArrays/v0.2.0 branch 2 times, most recently from 047fca2 to 8365f38 Compare August 30, 2017 17:02
@nalimilan
Copy link
Member

I've added more upper bounds to dependencies which needed them.

@nalimilan
Copy link
Member

JuliaCIBot failures seem to happen in spite of the upper bounds, so I guess they are expected? I'm not sure what the output should be.

@tkelman
Copy link
Contributor

tkelman commented Aug 30, 2017

MixedModels, ODBC, and RCall are going to be a bit complicated here, since the early versions of those didn't depend on CategoricalArrays.

@nalimilan
Copy link
Member

Of course that's what I have missed! Adding an upper bound on Julia 0.6 should be OK, right? These versions are quite old anyway and probably don't work there.

@nalimilan
Copy link
Member

I've added bounds on Julia 0.6 to MixedModels and RCall. ODBC already had them. I many cases 0.6 is clearly an overstatement, but checking what's the highest Julia release on which each released worked would be too much work; at least adding the bounds isn't worse than without it.

@tkelman
Copy link
Contributor

tkelman commented Aug 31, 2017

I wouldn't want to disallow installation of a version combination that does work correctly. What's the lowest Julia version supported by any CategoricalArrays tag? Instead of Julia upper bounds, could also add an artificial CategoricalArrays dependency for the purpose of adding an upper bound.

@nalimilan
Copy link
Member

What I meant by "overstatement" is that some releases of these packages are so old that they most probably don't work with Julia 0.6 (and maybe even not with 0.5 and 0.4). I've just tested locally, and MixedModels 0.5.8 (the most recent version to which I added the upper bound on Julia 0.6) does not pass its tests on Julia 0.6. RCall does not even load. So I think adding bounds on Julia 0.6 will be cleaner than adding a fake dependency on CategoricalArrays (though I don't care either way).

FWIW, the CategoricalArrays release supported Julia 0.4.

@nalimilan
Copy link
Member

Are the JuliaCI failures expected, despite upper bounds?

@tkelman
Copy link
Contributor

tkelman commented Sep 2, 2017

JuliaCIBot does things a bit wrong, it checks packages out instead of checking metadata out and letting version resolution do the rest. So until we fix that, it won't reflect bounds in the way users will see.

I tweaked a few things here, check if you agree with my commits here.

@nalimilan
Copy link
Member

Thanks for the fixes. Looks good to me, merge if that's OK for you too.

@tkelman tkelman merged commit a524223 into JuliaLang:metadata-v2 Sep 2, 2017
@attobot attobot deleted the CategoricalArrays/v0.2.0 branch September 2, 2017 13:49
@nalimilan
Copy link
Member

Thanks for your help with all these complex PRs @tkelman!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants