Tag CategoricalArrays.jl v0.2.0 #10987
Tag CategoricalArrays.jl v0.2.0 #10987
Conversation
@@ -0,0 +1,3 @@ | |||
julia 0.6- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you still need to support prereleases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really care, will remove on CategoricalArrays master for next time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you use struct
syntax, so 0.6-
isn't valid since that includes very early prereleases of 0.6 where that syntax didn't work yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've re-tagged the release and updated the PR.
2915119
to
95da5ee
Compare
This is based on #10969, shouldn't be merged before it because of |
95da5ee
to
94b1610
Compare
Sorry, I made a mistake when trying to update the Attobot branch. |
Repository: JuliaData/CategoricalArrays.jl --- 0.1.6/requires
+++ 0.2.0/requires
@@ -1,3 +1,3 @@
-julia 0.5.0
+julia 0.6
Compat 0.19.0
-NullableArrays
+Nulls 0.0.2 cc: @nalimilan Please make sure that:
|
94b1610
to
bf1af27
Compare
047fca2
to
8365f38
Compare
I've added more upper bounds to dependencies which needed them. |
8365f38
to
46bf7ea
Compare
JuliaCIBot failures seem to happen in spite of the upper bounds, so I guess they are expected? I'm not sure what the output should be. |
MixedModels, ODBC, and RCall are going to be a bit complicated here, since the early versions of those didn't depend on CategoricalArrays. |
Of course that's what I have missed! Adding an upper bound on Julia 0.6 should be OK, right? These versions are quite old anyway and probably don't work there. |
46bf7ea
to
ecbbcbf
Compare
I've added bounds on Julia 0.6 to MixedModels and RCall. ODBC already had them. I many cases 0.6 is clearly an overstatement, but checking what's the highest Julia release on which each released worked would be too much work; at least adding the bounds isn't worse than without it. |
I wouldn't want to disallow installation of a version combination that does work correctly. What's the lowest Julia version supported by any CategoricalArrays tag? Instead of Julia upper bounds, could also add an artificial CategoricalArrays dependency for the purpose of adding an upper bound. |
What I meant by "overstatement" is that some releases of these packages are so old that they most probably don't work with Julia 0.6 (and maybe even not with 0.5 and 0.4). I've just tested locally, and MixedModels 0.5.8 (the most recent version to which I added the upper bound on Julia 0.6) does not pass its tests on Julia 0.6. RCall does not even load. So I think adding bounds on Julia 0.6 will be cleaner than adding a fake dependency on CategoricalArrays (though I don't care either way). FWIW, the CategoricalArrays release supported Julia 0.4. |
Are the JuliaCI failures expected, despite upper bounds? |
170ae14
to
ffa18d4
Compare
instead of julia upper bound
JuliaCIBot does things a bit wrong, it checks packages out instead of checking metadata out and letting version resolution do the rest. So until we fix that, it won't reflect bounds in the way users will see. I tweaked a few things here, check if you agree with my commits here. |
Thanks for the fixes. Looks good to me, merge if that's OK for you too. |
Thanks for your help with all these complex PRs @tkelman! |
Repository: JuliaData/CategoricalArrays.jl
Release: v0.2.0
Diff: vs v0.1.6
requires
vs v0.1.6:cc: @nalimilan
Please make sure that: