Tag IntervalConstraintProgramming.jl v0.4.0 #7524
Tag IntervalConstraintProgramming.jl v0.4.0 #7524
Conversation
ValidatedNumerics 0.5.1 # plot recipes from 0.5.1 | ||
MacroTools 0.3 | ||
Compat 0.7.14 | ||
FixedSizeArrays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there no longer a minimum version requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll put it back. How do I do that with attobot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make the commit to master, then delete and re-submit the release (without closing this PR, somewhat oddly - it'll update in place)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/attobot/attobot#updatingdeleting-a-release for how to delete. It's not completely obvious.
You have a couple of pretty huge ipynb files in here, it's not always a good idea to put those in the git history. |
What's the alternative? |
separate repo, non-repo hosting, or attach them to github releases? |
None of those seem to be particularly good solutions IMO. |
Why not? These are semi-independent documentation, not part of the library code. Alternate branch would be another option but would make less of a difference. |
Yes, OK, true. |
Do you suggest I strip them completely from the history? If so, what's a sensible way to do that? |
Were they added in a single commit? Or did they exist at previously registered tags? This is one of the few cases where rebasing and force pushing to master can be worth the inconvenience, but should be careful to only rebase commits that aren't yet part of a published release tag. If you added them in a single commit, you can add a new commit that deletes them, then rebase relative to the commit right before the one that added them, and squash the deletion commit into the addition commit. |
They weren't added in a single commit. Some of them were in previous tags, although possibly with different names. It's a bit of a mess. |
Looks like JuliaIntervals/IntervalConstraintProgramming.jl@5a1caad is responsible for adding the really large ones. For smaller ones it's not worth rewriting history. |
Repository: dpsanders/IntervalConstraintProgramming.jl --- 0.3.0/requires
+++ 0.4.0/requires
@@ -1,6 +1,5 @@
julia 0.4
-ValidatedNumerics 0.5
+ValidatedNumerics 0.6 0.6.1
MacroTools 0.3
Compat 0.7.14
FixedSizeArrays 0.1.2
- cc: @dpsanders |
c871439
to
bfe2df2
Compare
I have (EDIT: rewritten history to) removed all the example notebooks out into a separate repo (linked from the README). |
Does that upper bound need to apply to past versions of the package? |
Good point. I'll send a separate PR for that.
Should the upper bound be written as "0.6+"?
…On Mon, Feb 6, 2017 at 12:11 PM, Tony Kelman ***@***.***> wrote:
Does that upper bound need to apply to past versions of the package?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7524 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALtTuKGjmcopvssZ7PUZrJqs6l6hLnDks5rZ2JIgaJpZM4Lfk7R>
.
--
Dr. David P. Sanders
Profesor Titular "B" / Associate Professor
Departamento de Física, Facultad de Ciencias
Universidad Nacional Autónoma de México (UNAM)
dpsanders@g <dpsanders@ciencias.unam.mx>mail.com / Twitter: @davidpsanders
<https://twitter.com/DavidPSanders>
http://sistemas.fciencias.unam.mx/~dsanders / GitHub: dpsanders
<https://github.com/dpsanders>
Cubículo / office: #414, 4o. piso del Depto. de Física
Tel.: (+52 55) 5622 4965
|
what do you want the upper bound to be? |
Allow 0.6.0 but not 0.6.1.
…On Mon, Feb 6, 2017 at 12:51 PM, Tony Kelman ***@***.***> wrote:
what do you want the upper bound to be?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7524 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALtThJ-6__5x7yNaJvOmC8TkoUc732zks5rZ2vJgaJpZM4Lfk7R>
.
--
Dr. David P. Sanders
Profesor Titular "B" / Associate Professor
Departamento de Física, Facultad de Ciencias
Universidad Nacional Autónoma de México (UNAM)
dpsanders@g <dpsanders@ciencias.unam.mx>mail.com / Twitter: @davidpsanders
<https://twitter.com/DavidPSanders>
http://sistemas.fciencias.unam.mx/~dsanders / GitHub: dpsanders
<https://github.com/dpsanders>
Cubículo / office: #414, 4o. piso del Depto. de Física
Tel.: (+52 55) 5622 4965
|
then 0.6.1 is most clear, the upper bounds are exclusive |
Also what are you breaking between patch releases? That's not usually supposed to happen. |
It turns out that v0.6.1 of VN does not play well once you import it into another package. (It works (?) but gives a lot of scary warnings.) |
you could supersede it with a v0.6.2 that reverts the offending commit or something? |
Please merge this once ValidatedNumerics 0.6.2 (reverting the offending commit) has been merged. |
won't you want to remove the upper bound then? |
Yes, but I don't know how to do that before until it is merged! |
there are instructions on the attobot readme |
I mean that master has changed since then. So I would make a new branch and do the release from that branch? |
Repository: dpsanders/IntervalConstraintProgramming.jl --- 0.3.0/requires
+++ 0.4.0/requires
@@ -1,6 +1,5 @@
julia 0.4
-ValidatedNumerics 0.5
+ValidatedNumerics 0.6
MacroTools 0.3
Compat 0.7.14
FixedSizeArrays 0.1.2
- cc: @dpsanders |
bfe2df2
to
ad4e136
Compare
ah, yes |
Why isn't |
Fixed, thanks. |
Should the tag be moved to JuliaIntervals/IntervalConstraintProgramming.jl@09f2467 then or were you going to make a 0.4.1 for that? Similarly with |
Repository: dpsanders/IntervalConstraintProgramming.jl --- 0.3.0/requires
+++ 0.4.0/requires
@@ -1,6 +1,5 @@
julia 0.4
-ValidatedNumerics 0.5
+ValidatedNumerics 0.6
MacroTools 0.3
Compat 0.7.14
FixedSizeArrays 0.1.2
- cc: @dpsanders |
ad4e136
to
53b517f
Compare
I have moved the tag. Thanks for your careful attention to these details! |
Repository: dpsanders/IntervalConstraintProgramming.jl
Release: v0.4.0
Travis:
Diff: vs v0.3.0
requires
vs v0.3.0:cc: @dpsanders