From 1f535cfc71f6730abe1d4f3fc0afca29a86e91d0 Mon Sep 17 00:00:00 2001 From: Mus Date: Thu, 31 Jan 2019 11:53:53 -0500 Subject: [PATCH 1/2] use === for comparisons to nothing --- src/snooping.jl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/snooping.jl b/src/snooping.jl index 0c2a5d32..1e9dc0da 100644 --- a/src/snooping.jl +++ b/src/snooping.jl @@ -7,7 +7,7 @@ function snoop(package, tomlpath, snoopfile, outputfile, reuse = false) using Pkg, PackageCompiler """ - if tomlpath != nothing + if tomlpath !== nothing command *= """ Pkg.activate($(repr(tomlpath))) Pkg.instantiate() @@ -31,11 +31,11 @@ function snoop(package, tomlpath, snoopfile, outputfile, reuse = false) run_julia(command, compile = "all", O = 0, g = 1, trace_compile = tmp_file) end used_packages = Set{String}() # e.g. from test/REQUIRE - if package != nothing + if package !== nothing push!(used_packages, string(package)) end usings = "" - if tomlpath != nothing + if tomlpath !== nothing # add toml packages, in case extract_used_packages misses a package deps = get(TOML.parsefile(tomlpath), "deps", Dict{String, Any}()) union!(used_packages, string.(keys(deps))) From fe7c1034fdfa608c24dc8b7b9108524da25d849f Mon Sep 17 00:00:00 2001 From: Mus Date: Thu, 31 Jan 2019 11:54:47 -0500 Subject: [PATCH 2/2] Update system_image.jl --- src/system_image.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/system_image.jl b/src/system_image.jl index bda101aa..530507cf 100644 --- a/src/system_image.jl +++ b/src/system_image.jl @@ -17,7 +17,7 @@ function compile_system_image(sysimg_path, cpu_target = nothing; debug = false) # At some point, I will need to understand build_object a bit better before doing that move, though! julia_cmd = Base.julia_cmd() julia = julia_cmd.exec[1] - cpu_target = if cpu_target == nothing + cpu_target = if cpu_target === nothing replace(julia_cmd.exec[2], "-C" => "") else cpu_target