wrong autocompletion in pkg mode

[matthias314]

If in pkg mode I type

pkg> add Static

then this is completed (in gray) to “add StaticArrays”. However, there are many other possible completions, and in fact the suggestion disappears when if I press TAB. According to @KristofferC this is a bug, see this Discourse posting.

Tested on Julia 1.11.2 and master.

[IanButterworth]

This is because #3913 was bad. We cannot stop early like that because hints figure out if there's a common prefix. Stopping early is confusing that. I recall we reverted it, but I cannot find evidence of it beyond a commit on an unknown branch IanButterworth@7003937

I also cannot revert #3913 via the github interface.

I think we can instead stop early as soon as there is no commonality to the completions collected.

[IanButterworth]

Ok, it was more that #3917 wasn't quite right.